New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: invalid browser name in karma config #14081
Conversation
test/karma.conf.js
Outdated
@@ -74,7 +73,7 @@ module.exports = (config) => { | |||
browserNoActivityTimeout: 300000, | |||
captureTimeout: 180000, | |||
|
|||
browsers: ['ChromeHeadlessLocal'], | |||
browsers: ['ChromeHeadless'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the real fix is to fix the browser name in the karma-browsers.json
. I messed up the search and replace and didn't really realize that it also affected ChromeHeadlessLocal
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
c75568e
to
f665415
Compare
Fixes the name of the default browser in the Karma config being invalid and throwing an error when running the tests locally.
Fixes the name of the default browser in the Karma config being invalid and throwing an error when running the tests locally.
Fixes the name of the default browser in the Karma config being invalid and throwing an error when running the tests locally.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes the name of the default browser in the Karma config being invalid and throwing an error when running the tests locally.