build: make sass bazel targets consistent #14186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes that the `list.scss` accidentally imports the `divider.scss` (while it just wants an actual mixin) * Fixes that the `cdk/a11y` package does not expose the `a11y-prebuilt.css` as Bazel target * Makes all `BUILD` files consistent in regards to Sass targets. * Ensures that each `sass_binary` or `sass_library` has it's **explicit** dependencies. Currently it's not possible to depend on a single target (depending on transitive build outputs/targets) * Removes the `_partials` filegroups because those can be replaced with a `sass_library` now. Also removes the `theme` sass_library in favor of the `_scss_lib`. Note that this does not change anything for the `theming_bundle` or `core:all_themes` target.
devversion
added
merge: caretaker note
devversion
requested review from
andrewseguin,
crisbeto,
jelbourn,
josephperrott and
mmalerba
as code owners
googlebot
added
the
cla: yes
|
Note: This is not merge safe because I fixed an issue with the |
devversion
removed
the
merge: caretaker note
|
Caretaker Note: This will require BUILD file updates internally with the new file created. |
josephperrott
added
pr: lgtm
action: merge
jelbourn
reviewed
Nov 27, 2018
| @@ -1,7 +1,7 @@ | |||
| @import '../core/style/variables'; | |||
| @import '../core/style/list-common'; | |||
| @import '../core/style/layout-common'; | |||
| @import '../divider/divider'; | |||
There was a problem hiding this comment.
@crisbeto don't we have a lint check that should have caught this?
There was a problem hiding this comment.
The lint check only checks the other way around. It reports if you have static CSS within a file starting with an underscore. (e.g. _divider-offset.scss)
devversion
added
the
merge: caretaker note
jelbourn
pushed a commit
that referenced
this pull request
Dec 3, 2018
* Fixes that the `list.scss` accidentally imports the `divider.scss` (while it just wants an actual mixin) * Fixes that the `cdk/a11y` package does not expose the `a11y-prebuilt.css` as Bazel target * Makes all `BUILD` files consistent in regards to Sass targets. * Ensures that each `sass_binary` or `sass_library` has it's **explicit** dependencies. Currently it's not possible to depend on a single target (depending on transitive build outputs/targets) * Removes the `_partials` filegroups because those can be replaced with a `sass_library` now. Also removes the `theme` sass_library in favor of the `_scss_lib`. Note that this does not change anything for the `theming_bundle` or `core:all_themes` target.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
* Fixes that the `list.scss` accidentally imports the `divider.scss` (while it just wants an actual mixin) * Fixes that the `cdk/a11y` package does not expose the `a11y-prebuilt.css` as Bazel target * Makes all `BUILD` files consistent in regards to Sass targets. * Ensures that each `sass_binary` or `sass_library` has it's **explicit** dependencies. Currently it's not possible to depend on a single target (depending on transitive build outputs/targets) * Removes the `_partials` filegroups because those can be replaced with a `sass_library` now. Also removes the `theme` sass_library in favor of the `_scss_lib`. Note that this does not change anything for the `theming_bundle` or `core:all_themes` target.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list.scssaccidentally imports thedivider.scss(while it just wants an actual mixin)cdk/a11ypackage does not expose thea11y-prebuilt.cssas Bazel targetBUILDfiles consistent in regards to Sass targets.sass_binaryorsass_libraryhas it's explicit dependencies. Currently it's not possible to depend on a single target (depending on transitive build outputs/targets)_partialsfilegroups because those can be replaced with asass_librarynow. Also removes thethemesass_library in favor of the_scss_lib. Note that this does not change anything for thetheming_bundleorcore:all_themestarget.