New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix failing nightly snapshot tests #14395

Merged
merged 2 commits into from Dec 6, 2018

Conversation

Projects
None yet
4 participants
@devversion
Member

devversion commented Dec 5, 2018

Apparently Yarn installs mismatching dependencies of Angular Github snapshot packages. Meaning that we need to flatten out all dependencies for @angular/* packages.

This can be achieved by using the Yarn's resolutions feature.

@devversion devversion requested a review from jelbourn as a code owner Dec 5, 2018

@googlebot googlebot added the cla: yes label Dec 5, 2018

@devversion devversion force-pushed the devversion:build/snapshot-tests-failing branch 4 times, most recently from 60eec6c to d4ed529 Dec 5, 2018

@devversion

This comment has been minimized.

Member

devversion commented Dec 5, 2018

Note: The size change seems unrelated. This PR is rebased on top of master. Maybe the size baseline hasn't been saved in master properly.

@jelbourn

LGTM

@ngbot

This comment has been minimized.

ngbot bot commented Dec 5, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/angular: size" is failing
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: tests_saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

devversion added some commits Dec 5, 2018

@devversion devversion force-pushed the devversion:build/snapshot-tests-failing branch from b71a96c to bb236d6 Dec 6, 2018

@mmalerba mmalerba merged commit a72d05f into angular:master Dec 6, 2018

13 checks passed

ci/angular: merge status All checks passed!
ci/angular: size No size change against base branch.
ci/circleci: bazel_build_test Your tests passed on CircleCI!
Details
ci/circleci: build_devapp_aot Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prerender_build Your tests passed on CircleCI!
Details
ci/circleci: publish_snapshots Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed

mmalerba added a commit that referenced this pull request Dec 10, 2018

build: fix failing nightly snapshot tests (#14395)
* build: fix failing nightly snapshot tests

* Fix comment typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment