Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix failing nightly snapshot tests #14395

Merged
merged 2 commits into from Dec 6, 2018

Conversation

devversion
Copy link
Member

@devversion devversion commented Dec 5, 2018

Apparently Yarn installs mismatching dependencies of Angular Github snapshot packages. Meaning that we need to flatten out all dependencies for @angular/* packages.

This can be achieved by using the Yarn's resolutions feature.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 5, 2018
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 5, 2018
@devversion devversion added the in progress This issue is currently in progress label Dec 5, 2018
@devversion devversion force-pushed the build/snapshot-tests-failing branch 4 times, most recently from 60eec6c to d4ed529 Compare December 5, 2018 22:52
@devversion
Copy link
Member Author

Note: The size change seems unrelated. This PR is rebased on top of master. Maybe the size baseline hasn't been saved in master properly.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 5, 2018
@ngbot
Copy link

ngbot bot commented Dec 5, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/angular: size" is failing
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: tests_saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba merged commit a72d05f into angular:master Dec 6, 2018
mmalerba pushed a commit that referenced this pull request Dec 10, 2018
* build: fix failing nightly snapshot tests

* Fix comment typos
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
* build: fix failing nightly snapshot tests

* Fix comment typos
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement in progress This issue is currently in progress target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants