New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change pink-bluegrey theme to pink-lightgreen #14764

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@beeman
Copy link

beeman commented Jan 9, 2019

@beeman beeman requested review from devversion and jelbourn as code owners Jan 9, 2019

@googlebot googlebot added the cla: yes label Jan 9, 2019

@jelbourn

This comment has been minimized.

Copy link
Member

jelbourn commented Jan 9, 2019

Removing the existing theme would be a breaking change without any real benefit. We can just add new prebuilt themes, though. I personally think the pink and green combination is a bit garish; how about a more muted primary color with a bright accent color?

@beeman

This comment has been minimized.

Copy link

beeman commented Jan 10, 2019

@jelbourn did not consider this would be a breaking change but you're right.

We could add another theme but that won't address the original issue where the accent color of pink-bluegrey is not very clear.

It's related to these values here where in dark mode the color hue 200 of the palette is used.

In case of the blue-grey palette that results in a very small difference.

image

Not sure if we want to address it after all, but if so we might want to pick a darker hue of the default accent palette.

@beeman beeman closed this Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment