Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update tooltip golden file #15479

Merged
merged 1 commit into from Mar 14, 2019
Merged

chore: update tooltip golden file #15479

merged 1 commit into from Mar 14, 2019

Conversation

crisbeto
Copy link
Member

Fixes the API golden check failing against master.

@crisbeto
chore: update tooltip golden file
d2cb76b 
Fixes the API golden check failing against master.
@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Mar 14, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 14, 2019
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Mar 14, 2019
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 14, 2019
@crisbeto crisbeto mentioned this pull request Mar 14, 2019
Merged
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 14, 2019
@ngbot
Copy link

ngbot bot commented Mar 14, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba merged commit 5f88cac into angular:master Mar 14, 2019
@mmalerba mmalerba added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Mar 18, 2019
Suresh918 pushed a commit to Suresh918/material2 that referenced this pull request Apr 15, 2019
@crisbeto
chore: update tooltip golden file (angular#15479)
f63e725 
Fixes the API golden check failing against master.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @googlebot @mmalerba