fix: error when attempting to access Intl API on some versions of Windows #15693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
…dows On some versions of Windows merely trying to access the `Intl` object can cause IE to throw an error, if the default `Map` object has been overwritten (e.g. when polyfilling). These changes add a `try/catch` around our usages so that users' apps don't crash completely on load. Fixes angular#15687.
crisbeto
force-pushed
the
15687/intl-api-error-ie
branch
from
b600e35
to
059a07c
Compare
devversion
approved these changes
Apr 2, 2019
|
@mmalerba could you please review ASAP? it's critical issue occur in our production environments |
mmalerba
added
the
P2
jelbourn
pushed a commit
that referenced
this pull request
Apr 4, 2019
…dows (#15693) On some versions of Windows merely trying to access the `Intl` object can cause IE to throw an error, if the default `Map` object has been overwritten (e.g. when polyfilling). These changes add a `try/catch` around our usages so that users' apps don't crash completely on load. Fixes #15687.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some versions of Windows merely trying to access the
Intlobject can cause IE to throw an error, if the defaultMapobject has been overwritten (e.g. when polyfilling). These changes add atry/catcharound our usages so that users' apps don't crash completely on load.Fixes #15687.