Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocomplete): panelClosingActions emitting when tabbing away from a closed autocomplete #8774

Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 2, 2017

Fixes the MatAutocompleteTrigger.panelClosingActions emitting when the user tabs away from an autocomplete that was closed already.

Fixes #8763.

@crisbeto crisbeto requested a review from kara as a code owner December 2, 2017 13:44
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 2, 2017
@crisbeto crisbeto force-pushed the 8763/autocomplete-closing-actions-tab branch from 6267ea5 to 0cc628e Compare December 2, 2017 23:01
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 5, 2017
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Dec 6, 2017
…m a closed autocomplete

Fixes the `MatAutocompleteTrigger.panelClosingActions` emitting when the user tabs away from an autocomplete that was closed already.

Fixes angular#8763.
@crisbeto crisbeto force-pushed the 8763/autocomplete-closing-actions-tab branch from 0cc628e to d3d3417 Compare December 10, 2017 18:08
@andrewseguin andrewseguin merged commit 92dcd76 into angular:master Dec 13, 2017
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Dec 19, 2017
…m a closed autocomplete (angular#8774)

Fixes the `MatAutocompleteTrigger.panelClosingActions` emitting when the user tabs away from an autocomplete that was closed already.

Fixes angular#8763.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MatAutocompleteTrigger.panelClosingActions emmiting even if the panel isn't being closed
4 participants