Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing all webdriver driver binaries through jvmArgs #5410

Open
praveendvd opened this issue Mar 14, 2020 · 0 comments
Open

Allow passing all webdriver driver binaries through jvmArgs #5410

praveendvd opened this issue Mar 14, 2020 · 0 comments

Comments

@praveendvd
Copy link

praveendvd commented Mar 14, 2020

In the current implementation of local.ts,

if the chrome driver path is not set in "chromeDriver" property in the config file, then local.ts will push "-Dwebdriver.chrome.driver=defaultpath".

https://github.com/angular/protractor/blob/5d8da049815ffc104e6eca71d2ecaec51b00f520/lib/driverProviders/local.ts

This creates two entries inside jvmArgs but only the later push ("which is the default one") will get precedence

image

Could there be an additional check to ensure that "-Dwebdriver.chrome.driver" or gecko driver is not already specified in jvmArgs? and push it only if jvmArgs doesn't have -Dwebdriver.chrome.driver specified.

Right now it's really confusing to use different approaches for different drivers.

localSeleniumStandaloneOpts: {
	port:5000,
        jvmArgs: ['-Dwebdriver.chrome.driver=C:/chromedriver.exe'],
},
@praveendvd praveendvd changed the title Allow passing chrome and firefox driver binaries through jvmArgs Allow passing all webdriver driver binaries through jvmArgs Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant