You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This creates two entries inside jvmArgs but only the later push ("which is the default one") will get precedence
Could there be an additional check to ensure that "-Dwebdriver.chrome.driver" or gecko driver is not already specified in jvmArgs? and push it only if jvmArgs doesn't have -Dwebdriver.chrome.driver specified.
Right now it's really confusing to use different approaches for different drivers.
The text was updated successfully, but these errors were encountered:
praveendvd
changed the title
Allow passing chrome and firefox driver binaries through jvmArgs
Allow passing all webdriver driver binaries through jvmArgs
Mar 14, 2020
In the current implementation of local.ts,
if the chrome driver path is not set in "chromeDriver" property in the config file, then local.ts will push "-Dwebdriver.chrome.driver=defaultpath".
https://github.com/angular/protractor/blob/5d8da049815ffc104e6eca71d2ecaec51b00f520/lib/driverProviders/local.ts
This creates two entries inside jvmArgs but only the later push ("which is the default one") will get precedence
Could there be an additional check to ensure that "-Dwebdriver.chrome.driver" or gecko driver is not already specified in jvmArgs? and push it only if jvmArgs doesn't have -Dwebdriver.chrome.driver specified.
Right now it's really confusing to use different approaches for different drivers.
The text was updated successfully, but these errors were encountered: