For versions of Protractor older than 0.21.0, dependency on minijasminenode needs to be fixed to exclude breaking changes

[mobrien-fexco]

(I'm new to the world of nodejs so excuse me if I've misunderstood something)

The new version of minijasminenode (1.0.0-alpha) released a few days ago is breaking protractor, which has a dependency on "minijasminenode": ">=0.2.7".

This should probably be changed to depend on 0.4.x or on versions < 1.0.0 (whatever seems best to you).

The breaking changes are responsible for the issues being discussed recently on Protractor issue #647 (which is actually a different issue). To reproduce the problem, all you have to do is check out the angular-seed project (or perhaps any protractor project) and try to run protractor tests.

[hankduan]

See #924, which opened a pull request for the seed project. But since that one is already closed, we can continue any discussion here if needed

[juliemr]

Please note that this is only a problem for versions older than 0.21.0, where there was an over-permissive dependency on minijasminenode. I'm updating the issue title to make this easier to find.

Since this issue has long been fixed in protractor, I'm not sure if there's any further action we can take to help mitigate the pain for anyone using an old version of protractor. We can't go back and edit their version, and we can't bump up the version of minijasminenode to something that won't be installed for them because >= is too permissive.

[juliemr]

Hi folks,

Summary: npm update and everything should work again.

So, releasing minijasminenode@1.0.0-alpha1 with breaking changes to support Jasmine 2 was a bad idea. This has been reverted. Now, minijasminenode@1.0.0 supports Jasmine 1.3, and should be compatible with older versions of protractor again.

We now have released a minijasminenode2@1.0.0 which supports Jasmine 2.0. This is not being used by Protractor at the moment, but may in the future.

Please let me know if there are any lingering issues or any confusion. Apologies for the breakages!

[shahbhatti]

I did the npm update and npm run protractor and I get the following:

0 info it worked if it ends with ok
1 verbose cli [ 'c:\Program Files\nodejs\node.exe',
1 verbose cli 'c:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js',
1 verbose cli 'run',
1 verbose cli 'protractor' ]
2 info using npm@1.4.9
3 info using node@v0.10.28
4 error Error: ENOENT, open 'c:\Users\sbhadi\angular-phonecat\app\phones\package.json'
5 error If you need help, you may report this entire log,
5 error including the npm and node versions, at:
5 error http://github.com/npm/npm/issues
6 error System Windows_NT 6.1.7601
7 error command "c:\Program Files\nodejs\node.exe" "c:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "run" "protractor"
8 error cwd c:\Users\sbhadi\angular-phonecat\app\phones
9 error node -v v0.10.28
10 error npm -v 1.4.9
11 error path c:\Users\sbhadi\angular-phonecat\app\phones\package.json
12 error code ENOENT
13 error errno 34
14 verbose exit [ 34, true ]