Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsickle npm version compatible with Angular v15 #1421

Closed
hipsterreed opened this issue Jan 31, 2023 · 3 comments
Closed

tsickle npm version compatible with Angular v15 #1421

hipsterreed opened this issue Jan 31, 2023 · 3 comments
Assignees

Comments

@hipsterreed
Copy link

Angular 15 requires typescript version 4.8 or above. The latest NPM published version of tsickle (0.46.3 as of the creation of this ticket) uses typescript version 4.7.2. I see that the master branch is currently using typescript version 4.9.4. Does anyone know when a new version of tsickle will be published to NPM?

@h-joo h-joo self-assigned this Feb 1, 2023
@frigus02
Copy link
Collaborator

frigus02 commented Feb 7, 2023

Quoting Martin from #1322:

Your Angular project should not depend on tsickle unless you've explicitly chosen to use tsickle (and most people shouldn't). If it does, there's some incorrect setup in your dependencies.

That said, we can push a new release.

@hipsterreed
Copy link
Author

Thanks for linking that issue as it had another thread linked in it on why I even encountered tsickle. Openapitools typescript-angular generates the angular library with tsickle as a dependency. If the lib is stable enough for a new release on npm that would be appreciated but if not i'll work around tsickle as i now see its has the warning for not supported. Thanks

@frigus02
Copy link
Collaborator

frigus02 commented Feb 7, 2023

Tsickle is only useful if you're using Closure Compiler. However that is probably not a good idea. Unless you're going all in and vet all dependencies to make sure they're compatible with Closure Compiler's optimizations, other minifiers such as terser or swc generally work better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants