Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsickle output preserves shorthand imports #288

Closed
alexeagle opened this issue Dec 1, 2016 · 1 comment
Closed

tsickle output preserves shorthand imports #288

alexeagle opened this issue Dec 1, 2016 · 1 comment
Assignees

Comments

@alexeagle
Copy link
Contributor

commonJS allows

folder/
  index.ts

to be imported with import {} from 'folder';
TypeScript allows the same convention, and in its --module=es6 output it preserves that import location.

However, this is unspecified and not supported by all bundlers, in particular closure compiler can't accept this ES6 output.

Tsickle is a good place for us to rewrite such imports to come from the canonical location.

@alexeagle
Copy link
Contributor Author

Fixed by that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant