Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misplaced type annotation #497

Closed
alexeagle opened this issue May 16, 2017 · 3 comments
Closed

Misplaced type annotation #497

alexeagle opened this issue May 16, 2017 · 3 comments
Assignees

Comments

@alexeagle
Copy link
Contributor

https://github.com/alexeagle/angular/blob/e1552b1745bf1eeb6f46b214c896605020ec67fd/packages/core/src/view/view.ts#L493

throw expressionChangedAfterItHasBeenCheckedError(
        Services.createDebugContext(view, nodeDef.index), `Query ${nodeDef.query!.id} not dirty`,
        `Query ${nodeDef.query!.id} dirty`, (view.state & ViewState.BeforeFirstCheck) !== 0);

=>

throw errors_1.expressionChangedAfterItHasBeenCheckedError(types_1.Services.createDebugContext(view, nodeDef.index), `Query ${ /** @type {?} */((nodeDef.query)).id} not dirty`, `Query ${ /** @type {?} */((nodeDef.query)).id} dirty`, (view.state & 1 /* BeforeFirstCheck */) !== 0);

third_party/javascript/angular2/rc/packages/core/src/view/view.closure.js:595:
Originally at:
../../../third_party/javascript/angular2/rc/packages/core/src/view/view.ts:489: ERROR - Misplaced type annotation. Type annotations are not allowed here. Are you missing parentheses?

@mprobst
Copy link
Contributor

mprobst commented May 16, 2017

I filed that upstream, it's a JSCompiler bug.

@evmar
Copy link
Contributor

evmar commented Sep 17, 2019

Obsolete?

@mprobst
Copy link
Contributor

mprobst commented Sep 17, 2019

Fixed on the Closure side, it no longer error on this.

@mprobst mprobst closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants