Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch untyped mode to emit @suppress {checkTypes} instead of @type {?}. #59

Closed
rkirov opened this issue Feb 11, 2016 · 3 comments
Closed

Comments

@rkirov
Copy link
Contributor

rkirov commented Feb 11, 2016

This means a lot less modifications of source and less opportunities to create invalid TS code though that.

@evmar
Copy link
Contributor

evmar commented Feb 25, 2016

I think I concluded that when you mix untyped code with typed code, you need the untyped-ness to propagate. However, I'd like to try doing this one more time before I just close this bug, so I can include an example of why it fails.

@mprobst
Copy link
Contributor

mprobst commented Feb 25, 2016

@martine I think John explicit said suppressing type warnings is preferable to {?}, in particular for optimizations to still work and not horribly fail. If just putting @suppress on files breaks other parts in horrible ways, then we of course shouldn't do it, but it's IMHO worth looking into. If only as a stepping stone on the way to completer type coverage.

@evmar
Copy link
Contributor

evmar commented Aug 20, 2019

We now emit types and @Suppress {checkTypes}.

@evmar evmar closed this as completed Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants