Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't forward declare if googmodule is false #797

Closed
2 tasks
dreamofabear opened this issue May 10, 2018 · 1 comment
Closed
2 tasks

Don't forward declare if googmodule is false #797

dreamofabear opened this issue May 10, 2018 · 1 comment

Comments

@dreamofabear
Copy link

Don't emit goog.forwardDeclare if goog.module conversion is disabled.

This is useful for JS projects that use (1) Closure Compiler and (2) ES6 modules (not Closure modules) that wish to incrementally start including TS files while preserving existing toolchain.

TODOs per discussion with @mprobst:

  • If googmodule is false, short circuit emittance of getForwardDeclareText()
  • Add golden file tests for this use case

Context: #758

@evmar
Copy link
Contributor

evmar commented Sep 17, 2019

We no longer goog.forwardDeclare, we goog.requireType. That probably means the same thing for this bug, but I think it then ends up being a dup of #1061, please correct me if I'm wrong!

@evmar evmar closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants