Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional route params with pre-rendered views #275

Closed
zanettin opened this issue Feb 15, 2016 · 10 comments
Closed

Optional route params with pre-rendered views #275

zanettin opened this issue Feb 15, 2016 · 10 comments
Assignees

Comments

@zanettin
Copy link

Related to this issue => angular/router#397 I'm not sure if this an issue or a missconfig from my side. Do I need to specify the route on the node side specialy or is it a bug from the router itself?

issue assigned to: @alexpods

@PatrickJS
Copy link
Member

We created our own version of Location Platform so this could really be our fault with the way we're managing the location. If it works on client then it should work with the server rendered view

@zanettin
Copy link
Author

Thanks for your fast reply. I'll close the other issue on angular/router.

@PatrickJS PatrickJS changed the title optional route params (Question / Bug?) Optional route params with pre-rendered views Feb 15, 2016
@PatrickJS
Copy link
Member

@alexpods will take this issue

@alexpods
Copy link

alexpods commented Mar 1, 2016

@zanettin @gdi2290 The bug is in core router library. More precisely it's here. As you can see urlParams are used only in _stringifyMatrixParams() which is called only if we have auxInstructions (see here). So if we don't have auxilary routes then urlParams will never be used.

@zanettin Could you open the issue in core angular2 repository?

UPDATE
toLinkUrl() is called here

@zanettin
Copy link
Author

zanettin commented Mar 1, 2016

thanks for your time @alexpods! i've re-opened the issue on the core router repo.

@zanettin zanettin closed this as completed Mar 1, 2016
@alexpods
Copy link

alexpods commented Mar 2, 2016

@zanettin I've also opened the issue in the core repository angular/angular#7367. I think the core team will be more active to close the issue there (at least I hope so).

@ganeshkbhat
Copy link

@ganeshkbhat
Copy link

Thank you... my bad.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants