Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

material 2 in angular 4.3 breaks #764

Closed
hakobpogh opened this issue Jul 31, 2017 · 11 comments
Closed

material 2 in angular 4.3 breaks #764

hakobpogh opened this issue Jul 31, 2017 · 11 comments

Comments

@hakobpogh
Copy link

I have tested material 2 in angular 4.3.x and it's not working. But your documentation says that in angular 4.1+ material 2 should fully work...

After build, when the express should start it throws an error "Unexpected token import" in file "/dist/ngfactory/node_modules/@angular/material/typings/index.ngfactory.ts:9/"

please help me to find out a solution...

@Toxicable
Copy link

Looks like an issue with Material not totally covering Universal support yet
Issue for tracking looks like this one angular/components#308

@dockleryxk
Copy link

Are you importing MaterialModule or are you importing the modules individually?

@hakobpogh
Copy link
Author

I'm including all the component modules individually @dockleryxk.

@Toxicable, when the material.angular will cover the universal? and when it'll be finally released? It looks like to be too long in beta version... and I looked at Polymer it looks like that its components are more pretty and more bugless. So maybe the material.angular team can work with Polymer team to finally give any release. Or can even take a look at their codes for fixing some UI issues.

@Toxicable
Copy link

@hakobpogh is still this an issue on the latest release of Material?

@hakobpogh
Copy link
Author

I've tested it for beta-10 release and the issue still exists.

@Toxicable
Copy link

@hakobpogh What issue? What error do you get with Universal?

@patrickmichalina
Copy link
Contributor

I have it working here https://angular.patrickmichalina.com

@hakobpogh
Copy link
Author

hakobpogh commented Sep 18, 2017

Thank you @patrickmichalina. But have you tested it with angular 4.* and not angular 5? Becuase the angular 5 is in beta yet so I'll prefer to use stable version instead.

@patrickmichalina
Copy link
Contributor

@hakobpogh yes angular 4.3 was how I started.

@Toxicable
Copy link

This should be fixed on the latest versions of Material.
If you still have an issue then open it up on the Material repo since that's where the root cause is

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants