Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix(spec): FakeAsyncTestZoneSpec.flush() passes limit along to scheduler #831

Merged
merged 1 commit into from Jul 12, 2017

Conversation

nertzy
Copy link
Contributor

@nertzy nertzy commented Jul 12, 2017

flush() in Angular's fakeAsync accepts a limit argument, which is passed to FakeAsyncTestZoneSpec.flush()

flush() on the Scheduler also accepts the limit argument. But FakeAsyncTestZoneSpec.flush() was not passing it along.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@nertzy
Copy link
Contributor Author

nertzy commented Jul 12, 2017

@mistuart-corelogic signed the CLA

@mistuart-corelogic
Copy link

I have signed the CLA

Signed-off-by: Michael Stuart <mistuart@corelogic.com>
@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@mhevery mhevery merged commit 667cd6f into angular:master Jul 12, 2017
@nertzy nertzy deleted the flush-limit branch July 23, 2017 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants