New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configureXaxis() uses attrs and not scope : why ? #57

Open

julienmeyer opened this issue Nov 21, 2013 · 1 comment

Contributor

julienmeyer commented Nov 21, 2013

In your function configureXaxis(), you test differents variables from attrs and not from scope. Why ?

You sould use a var x = attrs.X || scope.X and test value of 'x' no ?

My test : set xaxisrotatelabels to 20 for discretebar chart and it doesn't work if I don't change attrs to scope in configureXaxis.

Contributor

cmaurer commented Nov 25, 2013

@julienmeyer
Sorry for the delayed response on this. I am checking the attrs because that is where the variables are being set.

I do like your suggestion. It seems like it would simplify a lot of code.

Let me play around with it to see what it would entail.

Chris

cmaurer mentioned this issue

Discrete bar chart : set margin #51

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment