Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set neutral language to en-US #1311

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Set neutral language to en-US #1311

merged 1 commit into from
Sep 1, 2023

Conversation

ms-sio
Copy link
Contributor

@ms-sio ms-sio commented Aug 30, 2023 •
edited by angularsen
Loading

Fixes #1307

Set assembly neutral language to en-US for UnitsNet project

@ms-sio ms-sio changed the title Set neutral language to en-US (#1307) Set neutral language to en-US Aug 30, 2023
@ms-sio ms-sio mentioned this pull request Aug 30, 2023
Closed
@angularsen
Copy link
Owner

Will get to this soon

@angularsen angularsen merged commit 1970234 into angularsen:master Sep 1, 2023
1 check passed
@angularsen
Copy link
Owner

Excellent fix 👏
I tested with a console app and with LINQPad and both seem to work as before with this change.
Setting ru-RU as CurrentCulture shows Russian localization, while setting en-US or any other non-supported cultures uses English localization.

@angularsen
Copy link
Owner

Nuget should be out shortly.

Release UnitsNet/5.32.0 · angularsen/UnitsNet

@ms-sio ms-sio deleted the ms/neutral-language-en-us branch September 2, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UWP app en-US unit abbreviation resources not found for units with multiple languages defined
2 participants
@ms-sio @angularsen