feat(GST): Implement user timings #329
Conversation
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
==========================================
- Coverage 79.95% 79.69% -0.27%
==========================================
Files 30 30
Lines 898 911 +13
Branches 131 133 +2
==========================================
+ Hits 718 726 +8
- Misses 110 113 +3
- Partials 70 72 +2
Continue to review full report at Codecov.
|
src/lib/providers/gst/gst.ts
Outdated
| !properties.value | ||
| ) { | ||
| console.error( | ||
| 'Properties name, and value are required to be set.', |
There was a problem hiding this comment.
the typescript types already validate these exist right?
I think we can skip developer validation
There was a problem hiding this comment.
That's partially true because Typescript is compile-time only so at runtime you will lose all checks (or if somebody doesn't use Typescript compiler at all).
However, it is an Angular library, which has Typescript as the first-class citizen, so we can expect that TS will always be used.
I've removed the checks and left only undefined assert, otherwise, it could throw nasty Uncaught TypeError.
|
🎉 This PR is included in version 7.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What kind of change does this PR introduce?
A new feature into GST provider - user timings, related docs
What is the current behavior? Link to open issue?
User timings API is completely missing in GST
What is the new behavior?