Feat/styled component

[wincentrtz]

This is what i have done:

• Installing styled component dependencies
• Doing some folder refactoring on hello component
• Adding styled component on hello component

[anikethsaha]

Looks good to me
Left few suggestions
also, what do you think of making hello.js -> hello.jsx ?
You can convert that to class component too if you want!

[anikethsaha]

You can now make changes in your local machine and then push it to your branch itself. Thos will be reflected here automatically

[wincentrtz]

Actually there's no hello.js in this commit

I move it into a hello folder and put index.js and style.js inside. I guess that's better and it will make our import statement shorter too.

But if we want to keep it as hello.jsx, we can create a folder called styled with same level with test,

This is the current structured:

This is the structured I suggest if we want to keep file name as hello.jsx:

What do you think @anikethsaha ?

[anikethsaha]

Ohh sorry, my bad...I meant index.js -> index.jsx ?
No, you can keep it index itself ...the folder name hello looks good....we can keep everything related to that in that folder like tests and all 👍

[wincentrtz]

If we change it to index.jsx i guess there'll be a problem for javascript import statement. Where they can't detect index.jsx itself.

This is our previous import statement:

We dont need to specify index.js at the end of import statement, because it's index.js

but when we're using jsx i'm facing this kind of issue

and we need to add index.jsx at the end of import statement
is it okay?

[anikethsaha]

Yea I faced that too. Actually I changed all components to jsx and added .jsx at the end of the imports. I don't know why it's like that maybe some error in placing babel plugin.
Ok, you can leave it as it is. No need to change it for now.
Add some styles to the div (container) #114 (comment)
and then we are good to go for merging it 👍

[wincentrtz]

Awesome then!
I have pushed the new one @anikethsaha

Please check it once more :)

Thank you

[anikethsaha]

Good work 🎉

[anikethsaha]

@all-contributors please add @wincentrtz for code

[allcontributors]

@anikethsaha

I've put up a pull request to add @wincentrtz! 🎉