Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate AWS Chalice #116

Merged
merged 46 commits into from Aug 14, 2021
Merged

Integrate AWS Chalice #116

merged 46 commits into from Aug 14, 2021

Conversation

aniketmaurya
Copy link
Owner

@aniketmaurya aniketmaurya commented Aug 13, 2021

Changes

Fixes #106

Type of change

  • Documentation Update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@pep8speaks
Copy link

pep8speaks commented Aug 13, 2021

Hello @aniketmaurya! Thanks for updating this PR.

Line 60:101: E501 line too long (105 > 100 characters)

Comment last updated at 2021-08-14 12:39:51 UTC

@aniketmaurya aniketmaurya self-assigned this Aug 13, 2021
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #116 (fedd539) into master (35ae8f9) will increase coverage by 1.32%.
The diff coverage is 92.24%.

❗ Current head fedd539 differs from pull request most recent head 16322b6. Consider uploading reports for the commit 16322b6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   77.07%   78.40%   +1.32%     
==========================================
  Files          50       54       +4     
  Lines        1409     1528     +119     
==========================================
+ Hits         1086     1198     +112     
- Misses        323      330       +7     
Flag Coverage Δ
unittests 78.40% <92.24%> (+1.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
chitra/serve/cloud/aws_serverless.py 73.52% <73.52%> (ø)
chitra/image.py 78.88% <83.33%> (+0.31%) ⬆️
chitra/__init__.py 100.00% <100.00%> (ø)
chitra/serve/__init__.py 100.00% <100.00%> (ø)
chitra/serve/api.py 70.00% <100.00%> (ø)
chitra/serve/app.py 98.03% <100.00%> (+4.42%) ⬆️
chitra/serve/base.py 100.00% <100.00%> (ø)
chitra/serve/cloud/__init__.py 100.00% <100.00%> (ø)
chitra/serve/cloud/base.py 100.00% <100.00%> (ø)
tests/serve/cloud/test_chalice_server.py 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35ae8f9...16322b6. Read the comment docs.

@github-actions github-actions bot added the test add/update tests label Aug 13, 2021
@aniketmaurya aniketmaurya mentioned this pull request Aug 13, 2021
10 tasks
@aniketmaurya aniketmaurya added serve good first issue Good for newcomers labels Aug 14, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 14, 2021
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.4% 90.4% Coverage
0.0% 0.0% Duplication

@aniketmaurya aniketmaurya merged commit 34245ac into master Aug 14, 2021
@aniketmaurya aniketmaurya deleted the feature/chalice branch August 18, 2021 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers serve test add/update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serverless Model Deployment with Chalice
2 participants