Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Unknown train step #133

Merged
merged 4 commits into from Aug 23, 2021
Merged

Conversation

Adk2001tech
Copy link
Contributor

Changes

Fixes (Fixed yielding rate in the generator #129)

Type of change

  • added while loop in generator.
  • added training steps in model training
Before-

model training shoes unknown steps in 1st epoch itself.

Screenshot (45)



After-

this problem is solved simultaneously with this issue fixection.
Screenshot (47)

@aniketmaurya
Copy link
Owner

Hi @Adk2001tech, you can update the same PR instead of creating multiple 😀
Let me know if you need any help.

@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #133 (6ea1da9) into master (156e975) will decrease coverage by 0.03%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   78.89%   78.85%   -0.04%     
==========================================
  Files          53       53              
  Lines        1483     1485       +2     
==========================================
+ Hits         1170     1171       +1     
- Misses        313      314       +1     
Flag Coverage Δ
unittests 78.85% <25.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
chitra/trainer.py 51.48% <0.00%> (-0.26%) ⬇️
chitra/datagenerator.py 47.94% <100.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 156e975...6ea1da9. Read the comment docs.

@Adk2001tech
Copy link
Contributor Author

@aniketmaurya can you please clear why this 2 test are failing (codecov/patch)?
thanks

@aniketmaurya
Copy link
Owner

New code is not covered by unittest that's why code coverage is low

@Adk2001tech
Copy link
Contributor Author

New code is not covered by unittest that's why code coverage is low

Sir, can you elaborate. still having problem in tacking it.

@aniketmaurya
Copy link
Owner

The tests are written run using pytest and test files are present at https://github.com/aniketmaurya/chitra/blob/master/tests/test_trainer.py

Let me do some modifications and merge this for you. May be next time you can add tests.

@aniketmaurya aniketmaurya changed the title #129 Issue fixed fix Unknown train step Aug 23, 2021
Copy link
Owner

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@aniketmaurya aniketmaurya enabled auto-merge (squash) August 23, 2021 15:13
@aniketmaurya aniketmaurya merged commit cddc9fc into aniketmaurya:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants