Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Access Framework #336

Closed
DarremMolko opened this issue Jun 4, 2023 · 4 comments · Fixed by #555
Closed

Storage Access Framework #336

DarremMolko opened this issue Jun 4, 2023 · 4 comments · Fixed by #555

Comments

@DarremMolko
Copy link

Hi, I really love your video player. I noticed that it doesn't currently support accessing files stored in Document Providers. I was wondering if you would consider adding support for the Storage Access Framework to your app so users can easily access files from their preferred cloud storage providers. It would be a great addition to your already amazing app. Thanks!

@DarremMolko
Copy link
Author

@anilbeesetti Hi, and sorry for the ping. I just tried a debug build with this commit e8d062a and it works perfectly, but I noticed when I select the same video again it doesn't preserve the playback position, it starts from the beginning. Also how feasible is it to have a Resume fab to resume the last played media? Or maybe this is something unrelated and I should open a different issue.

@anilbeesetti
Copy link
Owner

Currently Next Player only preserve playback position of local media files. I will add remember playback position for other media in the future

@DarremMolko
Copy link
Author

@anilbeesetti I investigated some more about this and I found we could mount and access entire directories, in fact mpv-android let's you do exactly that. It could be a Fab in the main screen like the current file picker or a setting in the "Media library" settings.
Here is the documentation:
https://developer.android.com/training/data-storage/shared/documents-files#grant-access-directory
https://developer.android.com/reference/android/content/Intent#ACTION_OPEN_DOCUMENT_TREE

By the way, congratulations for publishing the app to the Play Store, I gave you 5 stars.

@DarremMolko
Copy link
Author

DarremMolko commented Sep 26, 2023

@anilbeesetti sorry for the ping but I noticed you closed this as completed but the player still doesn't remember the video playback position for videos opened through SAF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants