You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 15, 2022. It is now read-only.
Is your feature request related to a problem? Please describe.
In previous versions, there was a function to provide conversions from in-game FoV values to horizontal and vertical FoV values and to other in-game FoV values.
But there was a various set of issues which meant that it didn't always work correctly and the code was very confusing and use.
To reuse a lot of the code between the two functions/commands it may be useful to create a file in the helper's folder with functions that can be used
Describe alternatives you've considered
Implement the old code which is just too confusing and had too many flaws for the fovConvert command but could be implemented in the FoV command but because they are linked and the code was hard to understand it may be better to create the new one first and make sure there is no issues
This will prob need to be planned a lot around the implementation and the math involved so use this thread and or the dev channel in the support Discord server
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
In previous versions, there was a function to provide conversions from in-game FoV values to horizontal and vertical FoV values and to other in-game FoV values.
But there was a various set of issues which meant that it didn't always work correctly and the code was very confusing and use.
Describe the solution you'd like
Create a new command using the framework that I have already set up in https://github.com/animafps/fpsmath/blob/main/src/commands/Math/fov.ts and https://github.com/animafps/fpsmath/blob/main/src/commands/Math/fovConvert.ts
To reuse a lot of the code between the two functions/commands it may be useful to create a file in the helper's folder with functions that can be used
Describe alternatives you've considered
Implement the old code which is just too confusing and had too many flaws for the fovConvert command but could be implemented in the FoV command but because they are linked and the code was hard to understand it may be better to create the new one first and make sure there is no issues
Additional context
Old Versions: https://github.com/animafps/fpsmath/blob/984d3f3631f163f978d49dcc46401b0a1228e633/src/commands/math/fov.ts https://github.com/animafps/fpsmath/blob/984d3f3631f163f978d49dcc46401b0a1228e633/src/commands/math/fovConvert.ts
FILM Notation: https://www.kovaak.com/film-notation/
This will prob need to be planned a lot around the implementation and the math involved so use this thread and or the dev channel in the support Discord server
The text was updated successfully, but these errors were encountered: