Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add floating animation #1322

Closed
wants to merge 2 commits into from
Closed

Add floating animation #1322

wants to merge 2 commits into from

Conversation

cedricfortuin
Copy link

This is the pin: https://codepen.io/cedricfortuin-the-animator/pen/JjNdywr.

I missed this one in the docs and its quite a nice one for stuff like in the pin.

@warengonzaga
Copy link
Member

This is a good idea, we'll definitely add this and I'm gonna tweak it a bit. Can we add this to v5 @eltonmesquita?

Copy link
Member

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good move! ✔

@tiagorangel2011
Copy link

That's a good idea!

Copy link
Collaborator

@eltonmesquita eltonmesquita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this might get into the library, but it's still a bit rough on the edges. Check my comments and try to make it a bit smoother and with a more "organic" feel.

Comment on lines +2 to +7
from {
transform: translate3d(0, 0, 0);
}
to {
transform: translate3d(0, -40px, 0);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use some easing. It's a bit too stiff for a 'float' animation.

.floatItem {
animation: floatItem 3s;
animation-direction: alternate;
animation-iteration-count: infinite;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being only an infinite animation is not the best way to do this. Bake the return into the keyframe itself and don't rely on the animation-iteration-count property as many people use the keyframes directly.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not necessary but if u will use short hand property of animation it will be bater

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for every one

@eltonmesquita
Copy link
Collaborator

BTW, you'll also have to compile the source code using npm start.

@eltonmesquita
Copy link
Collaborator

Any news on the requested changes @cedricfortuin?

@warengonzaga
Copy link
Member

I guess no updates @eltonmesquita can I help with his PR?

.floatItem {
animation: floatItem 3s;
animation-direction: alternate;
animation-iteration-count: infinite;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not necessary but if u will use short hand property of animation it will be bater

.floatItem {
animation: floatItem 3s;
animation-direction: alternate;
animation-iteration-count: infinite;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for every one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants