New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
namespace classes #7
Comments
I'll consider this, but I don't think it will cause too much of a problem. Only the animation name is declared in these classes, no other properties, so the animation won't execute unless the user specifies it themselves. I also wanted to maintain as much consistency between the class names and the animation names as possible. |
The name collision is if for some reason the user have a class that have the same name but does something different. - i.e. adding a class PS: jQueryUI starts all their classes with |
Namespacing is probably a good idea, I prefer camel case over dashes myself. e.g |
I'm going to continue using the classes currently implemented. I've received no requests outside of this issue for namespaces, and the classes provided by animate.css contain no rules that risk overwriting any user set rules. |
I think it's a good idea to namespace all the classNames to avoid name collisions (eg.
.anim-flash
,.anim-fadeOut
, etc..) - it will be also easier to identify that class is only used for animation purposes.see SMACSS explanation about different types of rules.
PS: didn't suggested
.a-flash
,.a-fadeOut
becausea
is ambiguous (link element<a>
).The text was updated successfully, but these errors were encountered: