Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespace classes #7

Closed
millermedeiros opened this issue Oct 13, 2011 · 4 comments
Closed

namespace classes #7

millermedeiros opened this issue Oct 13, 2011 · 4 comments

Comments

@millermedeiros
Copy link

I think it's a good idea to namespace all the classNames to avoid name collisions (eg. .anim-flash, .anim-fadeOut, etc..) - it will be also easier to identify that class is only used for animation purposes.

see SMACSS explanation about different types of rules.

PS: didn't suggested .a-flash, .a-fadeOut because a is ambiguous (link element <a>).

@daneden
Copy link
Collaborator

daneden commented Oct 14, 2011

I'll consider this, but I don't think it will cause too much of a problem. Only the animation name is declared in these classes, no other properties, so the animation won't execute unless the user specifies it themselves.

I also wanted to maintain as much consistency between the class names and the animation names as possible.

@millermedeiros
Copy link
Author

The name collision is if for some reason the user have a class that have the same name but does something different. - i.e. adding a class flash would also make the element change the color or it would affect all the flash movies on the page (that already have a class flash on all the elements)

PS: jQueryUI starts all their classes with ui- for instance.

@Domw
Copy link

Domw commented Oct 17, 2011

Namespacing is probably a good idea, I prefer camel case over dashes myself. e.g .animFadeOut

@daneden
Copy link
Collaborator

daneden commented Nov 4, 2011

I'm going to continue using the classes currently implemented. I've received no requests outside of this issue for namespaces, and the classes provided by animate.css contain no rules that risk overwriting any user set rules.

@daneden daneden closed this as completed Nov 4, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants