Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on column_offset parameter for encode and encodeTo #2

Closed
yawaworthy opened this issue Feb 12, 2017 · 2 comments
Closed

Comments

@yawaworthy
Copy link

I noticed the encode and encodeTo functions take a col_offset parameter. I think I understand the idea (pick up where a previous encode left off), but couldn't think of a practical use case and didn't see your calls from Nyuu using it (so they get the default of 0). Is my understanding about it correct, and have you ever had to use it? Thanks.

@animetosho
Copy link
Owner

Yes, your understanding is correct. I can't think of any real practical use for it either (and have never had to use it); I suppose that in theory*, you could use it for implementing an incremental encoder for super-sized articles, or may be useful for future loop tiling optimisations (i.e. for yEnc+CRC), but for now, it's just there in case you ever need it.

* the functions never return the column they finish with, so it's not really that practical to use. Unfortunately, returning that kind of info is somewhat awkward in Javascript so I've left it out for now.

@yawaworthy
Copy link
Author

OK, thanks for the very complete answer. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants