Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change option name: from inmemoryBlockOnConsumed to inMemoryBlockOnConsumed #106

Closed
thernstig opened this issue Jan 27, 2021 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@thernstig
Copy link

Currently the API uses inmemoryBlockOnConsumed as an option, but it would be better if inMemoryBlockOnConsumed.

It is obviously more correct (camelCase), easier to read and it also does not give spelling error with spelling errors tools such https://github.com/streetsidesoftware/cspell

Any chance both inmemoryBlockOnConsumed and inMemoryBlockOnConsumed could be supported, where inMemoryBlockOnConsumed is mentioned in documentation and also takes precedence? I.e. the old name remains usable for backward compability.

@animir animir added the enhancement New feature or request label Jan 28, 2021
@animir animir changed the title inmemoryBlockOnConsumed vs. inMemoryBlockOnConsumed Change option name: from inmemoryBlockOnConsumed to inMemoryBlockOnConsumed Oct 30, 2021
@animir
Copy link
Owner

animir commented Sep 25, 2022

@thernstig Version 2.3.11 supports new inMemoryBlockOnConsumed and inMemoryBlockDuration options as well as just deprecated inmemoryBlockOnConsumed and inmemoryBlockDuration. Deprecated options will be supported until the next v3 major release.

@animir animir closed this as completed Sep 25, 2022
@thernstig
Copy link
Author

Hi @animir, how come release 2.3.11 did not show up at https://github.com/animir/node-rate-limiter-flexible/releases? I.e. there is no change log for users to be aware of this change.

@animir
Copy link
Owner

animir commented Oct 1, 2022

@thernstig It is there now. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants