Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return proper error while failing to update a User's profile #84

Closed
4 tasks done
isabelcosta opened this issue Jul 11, 2018 · 0 comments
Closed
4 tasks done

Return proper error while failing to update a User's profile #84

isabelcosta opened this issue Jul 11, 2018 · 0 comments
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Program: GSOC Related to work completed during the Google Summer of Code Program. Type: Bug Bug or Bug fixes.

Comments

@isabelcosta
Copy link
Member

isabelcosta commented Jul 11, 2018

Description

As reported in issue #83, when a User tries to update its username to an already existing one, the server responds with 500 - Internal Server Error. This happens because the Database model is aware that the username should be unique, hence it fails at saving the User new data.

This will require extra checks in DAO function that updates the User profile.

Acceptance Criteria

Update

  • Return proper error message when a user tries to update the username to an already existing one

Definition of Done

  • All of the required items are completed.
  • PR should be sent to the gsoc18-code branch.
  • Approval by 1 mentor.

Estimation

1 hours

@isabelcosta isabelcosta added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Program: GSOC Related to work completed during the Google Summer of Code Program. Type: Bug Bug or Bug fixes. labels Jul 11, 2018
@isabelcosta isabelcosta self-assigned this Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Program: GSOC Related to work completed during the Google Summer of Code Program. Type: Bug Bug or Bug fixes.
Projects
None yet
Development

No branches or pull requests

1 participant