Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

feat: Removed tabs when user does not has any relation. Fix for issue #122 #125

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

justdvnsh
Copy link

@justdvnsh justdvnsh commented Aug 3, 2020

Description

Removed the App bar when the user has no relation.

Fixes #122

Flutter Channel:

  • I have used the Flutter Beta channel on my local machine

Type of Change:

  • Code
  • Quality Assurance
  • User Interface

Code/Quality Assurance Only

  • New feature (Tab bar hides when user has no relation)

How Has This Been Tested?

https://drive.google.com/file/d/1AOvgBenhTe5d_GP-OcdszVjYKaufK1Jc/view?usp=sharing

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

@justdvnsh
Copy link
Author

@@ -0,0 +1,7 @@
/*___Generated_by_IDEA___*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitignore please

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justdvnsh any updates?

@@ -0,0 +1,7 @@
/*___Generated_by_IDEA___*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitignore

@justdvnsh justdvnsh changed the title feat: Removed tabs when user does not has any relation. Fix for issue… feat: Removed tabs when user does not has any relation. Fix for issue #122 Aug 3, 2020
@techno-disaster
Copy link
Contributor

@justdvnsh can you add a gif showing this? also can you check if pull down to refresh works in that gif? Thank you for your contribution.

@techno-disaster
Copy link
Contributor

Description

Removed the App bar when the user has no relation.

Fixes #122

Flutter Channel:

* [ ]  I have used the Flutter Beta channel on my local machine

Type of Change:

* Code

* Quality Assurance

* User Interface

Code/Quality Assurance Only

* New feature (Tab bar hides when user has no relation)

How Has This Been Tested?

https://drive.google.com/file/d/1AOvgBenhTe5d_GP-OcdszVjYKaufK1Jc/view?usp=sharing

Checklist:

* [*] My PR follows the style guidelines of this project

* [*] I have performed a self-review of my own code or materials

FYI its - [ x ] to check the box in markdown

@justdvnsh
Copy link
Author

@techno-disaster Yeah. sure. I will add the GIF and thanks for the checkmark information.

@justdvnsh
Copy link
Author

justdvnsh commented Aug 4, 2020

@techno-disaster Hi. Here is the GIF.
https://drive.google.com/file/d/1AmVMmgejjUruhOwkitXTigLP5uXcecBM/view?usp=sharing
Also, how can i remove .idea files from the commit.
I tried git rm --cached -r .idea but no luck !!

@techno-disaster
Copy link
Contributor

@justdvnsh Could you add the gif in the PR body itself? way more convenient for the other maintainers and myself to review. Also I'll manually test the PR later today and update. Thanks for your contribution

@justdvnsh
Copy link
Author

@techno-disaster The Gif is uploaded to google drive. I tried putting it in this PR body, but it is not happening. Only the link is being shared.

@techno-disaster
Copy link
Contributor

techno-disaster commented Aug 6, 2020

@techno-disaster The Gif is uploaded to google drive. I tried putting it in this PR body, but it is not happening. Only the link is being shared.

You should try adding the gif directly to the markdown not google drive, check this out

@Akanksha1212 Akanksha1212 added the Status: Changes Requested Changes are required to be done by the PR author. label Aug 7, 2020
@justdvnsh
Copy link
Author

Hi. @techno-disaster. I have changed the files according to the requested changes. Can you please review it now ?

@Akanksha1212 Akanksha1212 added the Category: Coding Changes to code base or refactored code that doesn't fix a bug. label Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Changes Requested Changes are required to be done by the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide tabs from Current Relation screen, when I don't have a mentorship relation
3 participants