Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Network call being done in transition from Member Profile to Send Request screen #121

Open
1 of 3 tasks
isabelcosta opened this issue Aug 1, 2020 · 10 comments · May be fixed by #138
Open
1 of 3 tasks

Network call being done in transition from Member Profile to Send Request screen #121

isabelcosta opened this issue Aug 1, 2020 · 10 comments · May be fixed by #138
Assignees
@yashhalgaonkar
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.

Comments

@isabelcosta
Copy link
Member

isabelcosta commented Aug 1, 2020 •
edited

Description

As a developer,
I need to avoid doing network calls when not needed,
so that I can spare the user's device resources.

I could not take a screenshot showing it, but when I click "Send Request" button on "Member Profile" screen I see the loading icon, indicating a call to the backend server is being done when transitioning to "Send Request" Screen. This should not be needed, as everything a the Send request screen needs comes from the member's profile which was already fetched previously and the user interface itself.

member profile screen send request screen
WhatsApp Image 2020-08-01 at 13 23 02 WhatsApp Image 2020-08-01 at 13 22 58

Acceptance Criteria

Update [Required]

  • Remove network call to backend server when transitioning from "Member Profile" to "Send Request" screen

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

4 hours
@isabelcosta isabelcosta added Type: Enhancement New feature or request. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Category: Coding Changes to code base or refactored code that doesn't fix a bug. labels Aug 1, 2020
@isabelcosta
Copy link
Member Author

@HaripriyaB do you want to try this issue? I see you tried one but ended up letting it go. If you wish to try this one I can assign this to you ;)

@techno-disaster
Copy link
Contributor

techno-disaster commented Aug 5, 2020 •
edited

@anitab-org/mentorship-flutter-maintainers can i take this up :)
cc: @anitab-org/mentorship-managers

@isabelcosta
Copy link
Member Author

@techno-disaster you have 7 issue assigned to you, can you please wait until we close some to start this one and leave some more time to other contributors to pick it. You are accumulating too many issues which are not merged yet

@techno-disaster
Copy link
Contributor

Sure np :)
I'll continue working on offline support. PR for that coming up soon too 🙂

@yashhalgaonkar
Copy link

Hey, @isabelcosta Can I take up this issue?

@techno-disaster
Copy link
Contributor

Sure, assigning it to you @yashhalgaonkar

@techno-disaster techno-disaster removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Aug 25, 2020
@yashhalgaonkar
Copy link

I have created a PR for this issue - https://github.com/anitab-org/mentorship-flutter/pull/138
For some reason, I am not able to link this issue and PR.

@yashhalgaonkar yashhalgaonkar linked a pull request Aug 26, 2020 that will close this issue
Open
9 tasks
@techno-disaster
Copy link
Contributor

I have created a PR for this issue - https://github.com/anitab-org/mentorship-flutter/pull/138
For some reason, I am not able to link this issue and PR.

done

@yashhalgaonkar
Copy link

Any review, suggestions? @isabelcosta @techno-disaster

@techno-disaster
Copy link
Contributor

Will review it today

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yashhalgaonkar yashhalgaonkar

Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.
Projects
None yet
Milestone
No milestone
3 participants
@isabelcosta @yashhalgaonkar @techno-disaster