Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eviction problem after using get command with binary protocol version #16

Closed
GoogleCodeExporter opened this issue Apr 25, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link
Contributor

binary protocol version:

get command increments refcount but doesn't decrement after command is
finished. The item cannot be evicted after this.

Works if adding a few lines to reset_cmd_handler function but not sure if
this is 100% fixing refcount problem in binary protocol version

static void reset_cmd_handler(conn *c) {
    if (c->item != NULL) {
        item_remove(c->item);
        c->item = 0;
    }

Original issue reported on code.google.com by victor.k...@sun.com on 12 Feb 2009 at 12:14

@GoogleCodeExporter
Copy link
Contributor Author

Original comment by victor.k...@sun.com on 13 Feb 2009 at 10:06

  • Changed state: New
  • Added labels: Priority-Critical
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Contributor Author

I've actually seen symptoms of this in my own tests.  Should be able to 
reproduce it
as a test case.

Original comment by dsalli...@gmail.com on 13 Feb 2009 at 11:38

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Contributor Author

Fixed in 72cb22b0ae7ecc1b536a0e4f4898556aba52e057

Original comment by dsalli...@gmail.com on 14 Feb 2009 at 6:00

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant