Make date and time formats configurable through options

[rept]

Hi @ankane

This is with regards to ankane/chartkick#445

I've added two options:

• date_format
• time_format

And kept the default values in case they aren't being used.

I'm not sure if the naming is clear like this. Happy to hear your feedback.

[ankane]

Hey @rept, thanks for the PR 👍 I think it'd be good to have a single option for setting the format regardless of the time unit. How about time_format / timeFormat (we'd want to allow both since some languages use camel case and others use underscore)?

[rept]

@ankane well my first thought was indeed creating a single option. However in the code the difference is made based on

hour || timeDiff > 0.5

How do you see a single option in that case?

[ankane]

A single option should work if you replace date_format with time_format. However, the PR currently only sets options.scales.xAxes[0].time.displayFormats for two conditions. It should set it anytime time_format is set.

[rept]

Sorry @ankane I'm not seeing how you can get both into time_format.

In one case we have:
"MMM D, h a"
in the other we have
"h:mm a"

How can you put both in one time_format string? I believe my naming isn't clear enough like I said in the first post. Maybe that's the confusing part.

About the other places where time_format should be set. I've searched the complete code but only found the string 'MMM D, h a' and 'h:mm a' in these 2 locations.

[ankane]

@rept If the user passes time_format: "MMM" to Chartkick, it should set options.scales.xAxes[0].time.displayFormats and options.scales.xAxes[0].time.tooltipFormat to that format.

[ankane]

Cleaning up stale PRs