Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds xtitle & ytitle options #48

Merged
merged 1 commit into from Sep 1, 2015
Merged

Adds xtitle & ytitle options #48

merged 1 commit into from Sep 1, 2015

Conversation

buren
Copy link
Contributor

@buren buren commented Aug 25, 2015

Support for hAxisTitle & vAxisTitle options for all charts.

As per #47 (comment)

Do you like the option names? I had some trouble choosing what to use.. xAxis, xAxisLabel, xAxisTitle etc etc...

@ankane
Copy link
Owner

ankane commented Aug 27, 2015

What do you think of xtitle and ytitle?

@buren
Copy link
Contributor Author

buren commented Aug 27, 2015

Updated and squashed :)

@ankane
Copy link
Owner

ankane commented Aug 27, 2015

Cool, I won't be around later this week, but I'll get this merged next week.

@buren
Copy link
Contributor Author

buren commented Aug 27, 2015

Sweet 👍

@buren buren changed the title Adds hAxisTitle & vAxisTitle options Adds xtitle & ytitle options Aug 27, 2015
@ankane ankane merged commit 9f35e2f into ankane:master Sep 1, 2015
@ankane
Copy link
Owner

ankane commented Sep 1, 2015

Merged, thanks!

@ankane
Copy link
Owner

ankane commented Sep 1, 2015

Also, pushed a new version of chartkick.js and the chartkick gem with this and the scatter charts 👍

@buren
Copy link
Contributor Author

buren commented Sep 1, 2015

Sweet 👑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants