Adjust time format in maintenance listing table to include year #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @samudary, thanks for the PR! Agree it be better to make it less ambiguous. What do you think of showing the relative time in the table (like "5 months ago"), with full time in a |
|
@ankane I like that! Pushed another commit with that change. Example:
|
ankane
reviewed
Mar 12, 2021
app/helpers/pg_hero/home_helper.rb
Outdated
| @@ -26,5 +26,15 @@ def pghero_remove_index(query) | |||
| ret << ", column: #{columns.inspect}" if columns | |||
| ret | |||
| end | |||
|
|
|||
| def formatted_vacuum_times(time) | |||
There was a problem hiding this comment.
Let's prefix helpers with pghero_ since I think these will be global.
There was a problem hiding this comment.
Good call! Updated
app/helpers/pg_hero/home_helper.rb
Outdated
| end | ||
|
|
||
| def formatted_date_time(time) | ||
| l time.in_time_zone(@time_zone), format: "%d %b %Y %H:%M" |
There was a problem hiding this comment.
Think we can probably use :long since it no longer needs to fit into the table cell.
|
Thanks @samudary! |
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
elguapo1611
pushed a commit
to instacart/pghero
that referenced
this pull request
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #363
Rails only includes the following time format options: https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/en-US.yml#L211-L214
To make the timestamp displayed for the last vacuum or analyze less ambiguous I decided to add a year. I provided a custom format string to maintain the existing "day short_month ... 24-hour clock time" format instead of using
:longwhich would completely change the order.Example: