Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misspelling request does not take into account body changes #1244

Closed
jfloff opened this issue Mar 20, 2019 · 1 comment
Closed

Misspelling request does not take into account body changes #1244

jfloff opened this issue Mar 20, 2019 · 1 comment

Comments

@jfloff
Copy link

jfloff commented Mar 20, 2019

According to #661 If too few results are returned with no misspellings a second search is performed.

What I found is that if we have changes to the body with the yield block,

Item.search(text, options) do |body|
   ...
end

the second query its not taking into account the changes to the body that we defined in the yield block, only the first query is.

@ankane ankane closed this as completed in a9041a9 Mar 21, 2019
@ankane
Copy link
Owner

ankane commented Mar 21, 2019

Hey @jfloff, thanks for reporting 👍 Fixed on master.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants