Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Music Video library support #5

Closed
TheCodingDutchman opened this issue Apr 21, 2020 · 8 comments
Closed

Add Music Video library support #5

TheCodingDutchman opened this issue Apr 21, 2020 · 8 comments

Comments

@TheCodingDutchman
Copy link

Could there be an ID field in the identify tab of a video?
Also, how should the file be called? The Youtube-dl name? Only the video title? The id? Please clarify this in the readme.
Could support be added to a Music Video library?

@TheCodingDutchman
Copy link
Author

Figured out how they need to be called now, it needs to have the id between brackets: [ID]. Please add that to the readme

@ankenyr
Copy link
Owner

ankenyr commented Apr 22, 2020

Could there be an ID field in the identify tab of a video?

Yes I had planned on doing this soon. Will create a PR specifically for that.

Also, how should the file be called? The Youtube-dl name? Only the video title? The id? Please clarify this in the readme.

Will add this to my next push

Could support be added to a Music Video library?

Not sure what is lacking to make it available for a Music Video library. Does it not appear on the list of available metadata downloaders?

@ankenyr
Copy link
Owner

ankenyr commented Apr 22, 2020

Made issue #6 to track the ID issue.

@TheCodingDutchman
Copy link
Author

TheCodingDutchman commented Apr 22, 2020

Ok, thanks!

Not sure what is lacking to make it available for a Music Video library. Does it not appear on the list of available metadata downloaders?

Yeah, I can't see it on the list

@mistergoodwin
Copy link

mistergoodwin commented Apr 23, 2020

Not sure what is lacking to make it available for a Music Video library. Does it not appear on the list of available metadata downloaders?

See in YoutubeProvider.cs

namespace Jellyfin.Plugin.YoutubeMetadata
{
    public class YoutubeMetadataProvider : IRemoteMetadataProvider<Movie, MovieInfo>, IHasOrder

Specifically IRemoteMetadataProvider<Movie, MovieInfo>

make it available for a Music Video library

+TV Shows library too.

@ankenyr
Copy link
Owner

ankenyr commented Apr 23, 2020

This issue is starting to get overloaded. @mistergoodwin would you mind making a separate issue for TV shows? I have a few follow up questions on how that could or should be implemented.

@GameMaster2030 Is there anything left in this request besides enable the plugin for Music Videos? I updated the README to provide instructions on how the files should be named in 10b59a7. If the music video request is all that is left I will change the title to reflect that.

@TheCodingDutchman
Copy link
Author

TheCodingDutchman commented Apr 23, 2020

Yeah, that's the only thing left

@TheCodingDutchman TheCodingDutchman changed the title Some requests and questions Add Music Video library support Apr 23, 2020
@ankenyr
Copy link
Owner

ankenyr commented Jun 29, 2020

Sorry that took so long, got really busy at work. Just added this as a feature. Please file a new issue if you find any problems.

@ankenyr ankenyr closed this as completed Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants