Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort flag similarities by importance #225

Closed
josealberto4444 opened this issue Mar 19, 2020 · 3 comments · Fixed by #227
Closed

Sort flag similarities by importance #225

josealberto4444 opened this issue Mar 19, 2020 · 3 comments · Fixed by #227
Assignees
Labels
chore Documentation, licenses, repository structure, dependency upgrades, etc.
Milestone

Comments

@josealberto4444
Copy link
Collaborator

As I might have some doubts (and for remembering), I will open this issue. I plan to do it myself, but I don't know how to assign the issue to my user (I don't usually use GitHub, to be honest).

@axelboc axelboc added the chore Documentation, licenses, repository structure, dependency upgrades, etc. label Mar 19, 2020
@axelboc axelboc added this to the v3.3 milestone Mar 19, 2020
@josealberto4444
Copy link
Collaborator Author

josealberto4444 commented Mar 21, 2020

I've changed Nicaragua/El Salvador to different coat of arms, slightly lighter/darker blue, as the latter difference is negligible (ΔE = 15.3). However, I wonder if we should even say that, as there is already a minor difference, following the guidelines:

Critical, major and minor differences should be listed in the Flag similarity field. Negligible differences should be listed only when relevant, notably when two flags share nothing but negligible differences.

If you think it's relevant, I have no problem in keeping it.


By the way, it is the only place where the appropriate sorting was not enforced. The differences were already sorted everywhere else.

@aplaice
Copy link
Collaborator

aplaice commented Mar 21, 2020

Given that the coat of arms are pretty similar (both are based on a triangular motif, with some details added), it might, perhaps, be worth keeping the colour difference.

Technically, it wouldn't be against the guidelines, since those give the case with only negligible differences as the central example, but not the only possibility. Also, one could argue that there should be an additional negligible difference category:

subtly different decoration of same type in same position (e.g. different symbol, different coat of arms)

(This opens up the can of worms of what a subtle difference is, but then the distinction in subtle and not subtle geometry differences also isn't rigorously defined.)

I'm not wholly convinced myself, though...

@axelboc
Copy link
Collaborator

axelboc commented Mar 21, 2020

By the way, it is the only place where the appropriate sorting was not enforced. The differences were already sorted everywhere else.

Awesome, thanks for having a look!

The difference in coat of arms in this case is indeed quite negligible, so let's keep listing the negligible colour difference. The word should means the guidelines technically still apply, even without the addition of a negligible difference category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Documentation, licenses, repository structure, dependency upgrades, etc.
Development

Successfully merging a pull request may close this issue.

3 participants