Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Czech translation #339

Closed
Flippo008 opened this issue Jun 22, 2020 · 16 comments · Fixed by #377
Closed

Czech translation #339

Flippo008 opened this issue Jun 22, 2020 · 16 comments · Fixed by #377
Labels
translation Translating the deck to a new language
Milestone

Comments

@Flippo008
Copy link
Collaborator

Hi,
I read #313 and my case is totally the same. I have been learning Ultimate geography and making my own Czech translation because for me is crucial to know the names of countries etc. in my language. After v4.0 release I am planning to make a clean import and start from a scratch since the translation wasn't as good as I would like to be for public sharing. Same as hoi3 I don't know how to proceed correctly and I also read your answer that the maximum number of translation was reached. But I will make the Czech translation for my purpose regardless of sharing the translation to other people, so if the work could be incorporated later in the deck, that would be just a sweet bonus for me.

Sorry for eventual mistakes in this issue, obviously I am not a native speaker.

I am looking forward to v4.0 of Ultimate geography.

@axelboc axelboc added translation Translating the deck to a new language better-deck-manager Improvements feasible with a better deck manager labels Jun 22, 2020
@axelboc

This comment has been minimized.

@aplaice

This comment has been minimized.

@axelboc

This comment has been minimized.

@aplaice
Copy link
Collaborator

aplaice commented Jul 11, 2020

(Replying to #340 (comment)):

Sorry for the late response, I was a couple of days off PC.

No problem!

I copied my data to data.csv in translation branch, so if I did it right, you should be able to check my translation.

Thanks very much! I understand that the translation is here?

There seems to be an encoding issue (e.g. there's Afghánistán instead of Afghánistán and so on). It almost looks like Windows-1250 (?) encoded as UTF-8, but not quite. However, I'm not sure what caused it. :( (It might have been anki-dm or CrowdAnki's interplay with the system locale or even a copy-paste encoding issue.) Could you perhaps upload your CrowdAnki deck.json as a GitHub gist?

A second issue is that there are unnecessary HTML tags <div> and </div> inserted into the fields, which is definitely Anki's fault (it adds them when you insert a new line, and keeps them there, even when they're no longer needed). However, they could be straightforwardly removed once this is ready for merging, so don't worry about them.


In any case, I'm looking forward to getting the Czech translation in, once we have the new deck manager! :)

@Flippo008
Copy link
Collaborator Author

I am back. I apologize for not responding, I was on summer camp, so I couldn't really upload the wanted file. Sorry. Here is URL for deck.json uploaded as GitHub gist.

https://gist.github.com/Flippo008/2c59d9abc4c273a6e7a84c3a74cfc729

@aplaice
Copy link
Collaborator

aplaice commented Jul 29, 2020

Thanks very much!

deck.json doesn't have any encoding issues, so I guess that the problem had been caused by PHP during anki-dm's conversion of deck.json into data.csv. Since we'll be switching away from anki-dm it's not worth delving deeper.

On a cursory look through the translation (by a non-Czech speaker), it looks great! :)

@ohare93
Copy link
Member

ohare93 commented Jan 16, 2021

New deck manager has been pulled 👍 The source csv has now been broken into multiple separate csv files inside src/data.

You can now add your translation 👏 This requires 2 steps to do it yourself:

  1. Add the translation as a column in each of the source files.
  2. Edit the Brain Brew recipe in recipes/source_to_anki.yaml to build your new column to your new language deck. Just copy pasting what the others do, and changing it to match your new columns will do 👍

I am happy to do the second step, if you do the first 😉

Better yet, if you have created the translation inside Anki itself then I can do it all in <5mins, as the new deck manager can also import from CrowdAnki to our Source control. Feel free to export the deck, upload a zip of it here, and I will do magic 👏 😁

@axelboc axelboc removed the better-deck-manager Improvements feasible with a better deck manager label Jan 16, 2021
@aplaice
Copy link
Collaborator

aplaice commented Jan 16, 2021

Better yet, if you have created the translation inside Anki itself then I can do it all in <5mins, as the new deck manager can also import from CrowdAnki to our Source control. Feel free to export the deck, upload a zip of it here, and I will do magic clap grin

I think that @Flippo008 has already produced a deck.json above, so apart from content changes to the deck since July, the translation is probably mostly ready!

@aplaice
Copy link
Collaborator

aplaice commented Jan 16, 2021

@Flippo008, if you're still willing to continue with your translation, (no pressure! and sorry for the delay!), then all that we'd need to finish would be for a couple of translations of the minor changes and additions, since then, if/when you have time.

AFAICT your translation was based on the stable v4.0 release. The following relevant content changes have been made since v4.0:

  1. Change of the name of the "continent"/"part of the world" Australia to Oceania, and an addition of a "Country info":

    World region covering the Australian continent and most of the islands in the Pacific Ocean.
    

    We decided that it made more sense in the context of the deck to have Oceania rather than Australia, especially since that's what the map shows. (I think that the distinction between Australia and Oceania is the same in English as in Czech.)

  2. Addition of 7 new notes (with only Map → Country cards, and hence only needing translation of the Country name and the Country info):

Country Country info
Wallis and Futuna Overseas territory of France.
Akrotiri and Dhekelia Overseas territory of the United Kingdom.
Svalbard Unincorporated internal area of Norway.
Hawaii State of the United States.
Alaska State of the United States.
Bougainville Autonomous region of Papua New Guinea.
Jeju Autonomous province of South Korea.

Overall, I think that it'd be easiest if you just give the translations of the 7 new "Country" names and 8 "Country infos" (Oceania and the 7 new ones) here, which I (or @ohare93) could add on top of your CrowdAnki deck from above — otherwise you and we might have issues with overwriting of changes/GUIDs etc. (At the end of the process you'll be able to update your current Anki deck, with the updated version (including new notes!), as translated by you, without loss of your current translation/notes, and you'll also be able to easily continue updating the deck in the future.)

@Flippo008
Copy link
Collaborator Author

Glad to hear this good news. Yes, you are correct that my translation was based on v4.0 release. So if I understand correctly, I write these changed/added information here and you will edit it. So:

Austrálie (Oceánie) -> Oceánie
Country info: Světová oblast zahrnující australský kontinent a většinu ostrovů v Tichém oceánu.

here is a table with a corresponding order

Country Country info
Wallis a Futuna Zámořské území Francie.
Akrotiri a Dekelia Zámořské území Velké Británie.
Špicberky Nezařazené území Norska.
Havaj Stát spojených států.
Aljaška Stát spojených států.
Bougainville Autonomní území státu Papua Nová Guinea.
Čedžu Autonomní provincie Jižní Koreji

I know we are respecting title of Wikipedia page and as it seems when it is obvious that info is redundant, it gets deleted.
e.g. Autonomous Region of Bougainville -> Bougainville

And id I understood correctly, in the future I will have access to a file (like data.cvs) where I can edit new deck updates or some minor translation mistakes.

@aplaice
Copy link
Collaborator

aplaice commented Jan 17, 2021

@Flippo008 Thanks for the very fast reply and for the translations!

So if I understand correctly, I write these changed/added information here and you will edit it.

Yes. (Otherwise creating an appropriate deck.json with correct GUIDs could have been messy.)

I know we are respecting title of Wikipedia page and as it seems when it is obvious that info is redundant, it gets deleted.
e.g. Autonomous Region of Bougainville -> Bougainville

Yes, exactly, like you've translated.

And id I understood correctly, in the future I will have access to a file (like data.cvs) where I can edit new deck updates or some minor translation mistakes.

Yes! It's now split between several files, but the idea is exactly the same.


@ohare93 can I do the magic, given that I had volunteered slightly more than you had volunteered? Or do you want to do the magic and I'll add the several manual translations to the CSVs, as a pull request on top of that?

@ohare93
Copy link
Member

ohare93 commented Jan 17, 2021

@ohare93 can I do the magic, given that I had volunteered slightly more than you had volunteered? Or do you want to do the magic and I'll add the several manual translations to the CSVs, as a pull request on top of that?

Yes please! 😁 🤝

@aplaice
Copy link
Collaborator

aplaice commented Jan 17, 2021

@ohare93, (I think) I've done some of the magic and imported the Czech translation, but the sorting of all the CSV files is reset to alphabetical. Do you have any tips for getting around this?

@ohare93
Copy link
Member

ohare93 commented Jan 17, 2021

@ohare93, (I think) I've done some of the magic and imported the Czech translation, but the sorting of all the CSV files is reset to alphabetical. Do you have any tips for getting around this?

Pull (or just redo) my changes to the recipe files here I just faced a similar annoyance doing the Russian translation 😅

@ohare93
Copy link
Member

ohare93 commented Jan 17, 2021

Taking out the sorting will only make it not sort in the future, it will not undo the sorting it has already done. So you may have to rollback your changes to the split csvs and run the recipe again. Hopefully that won't mean you have to redo too much! 😓

I have included removing the sorting in the Russian translation PR, so this should not happen again.

@aplaice
Copy link
Collaborator

aplaice commented Jan 17, 2021

That worked, thanks! :)

(And no, I didn't need to redo much! :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translating the deck to a new language
Development

Successfully merging a pull request may close this issue.

4 participants