Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fastlane for automated locale screenshots #10091

Open
jaiakash opened this issue Jan 4, 2022 · 6 comments
Open

Use fastlane for automated locale screenshots #10091

jaiakash opened this issue Jan 4, 2022 · 6 comments
Labels
Dev Development, testing & CI Keep Open avoids the stale bot

Comments

@jaiakash
Copy link

jaiakash commented Jan 4, 2022

The project has screenshots of the app in various languages. But it did not have in the Hindi language.
So I would like to add screenshots in hindi language.

@welcome
Copy link

welcome bot commented Jan 4, 2022

Hello! 👋 Thanks for logging this issue. Please remember we are all volunteers here, so some patience may be required before we can get to the issue. Also remember that the fastest way to get resolution on an issue is to propose a change directly, https://github.com/ankidroid/Anki-Android/wiki/Contributing

@david-allison
Copy link
Member

david-allison commented Jan 12, 2022

I have a few issues here now I've had time to get into our infra around these screenshots:

Uploading Infra
The screenshots are uploaded by https://github.com/ankidroid/Anki-Android/blob/master/tools/google-play.py, but this doesn't seem to have been maintained in quite a while.

  • Our new screenshots by Mani are not consistent with this script, and would be wiped
  • The script may not work
  • The original upload (MD screen shots #3897) appears to be a lot of work
  • Each screenshot update will bloat the git repo

Manual work
I don't think we want to do this manually, because keeping the screenshots in-line is a lot of effort

  • It's a lot of manual maintenance to get two people's devices to look similar, load the appropriate cards etc..
  • It makes it a lot harder to change content if we want better screenshots

Conclusion (I'd like to see what other maintainers say) @mikehardy @Arthur-Milchior:

I think we should log an issue to improve this screenshot mechanism. I'd expect that we'd use fastlane or similar automation. I don't think we should be spending time on manual screenshots

@mikehardy
Copy link
Member

Fastlane, it's the answer. I've got a few projects that use it now, mostly iOS but I finally did an Android one with ABB files and it's the ticket. It's a big job though, the whole package and upload and store presence system needs an overhaul and these would just be a content part of It

@mikehardy
Copy link
Member

To elaborate a little on the fastlane comment - fastlane can actually drive the app and take screenshots even, so the work here would actually be to create locale-specific collections for each language that wanted screenshots such that there was a demonstration card, maybe via creating strings crowdin can consume and then some process to create collections from those strings, then doing the necessary glue/binding to fastlane to load the collection per-locale and drive the app to the card and take the screenshot into the locale folder, followed by using fastlane's store presence features to upload screenshots while pushing releases.

It's not a small job but fastlane owns this space now (via community consensus + raw effort in the fastlane project to make it the best) and that's how I'd design it out if I was asked for an ideal future state

@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Mar 13, 2022
@david-allison david-allison changed the title [Screenshot] Hindi Langauge Use fastlane for automated locale screenshots Mar 13, 2022
@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label May 12, 2022
@mikehardy mikehardy added Keep Open avoids the stale bot Dev Development, testing & CI and removed Stale labels May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Development, testing & CI Keep Open avoids the stale bot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants