Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Don't clear previous activities when a shortcut is launched #10970

Open
BrayanDSO opened this issue Apr 19, 2022 · 16 comments
Open
Labels
Keep Open avoids the stale bot

Comments

@BrayanDSO
Copy link
Member

BrayanDSO commented Apr 19, 2022

Is your feature request related to a problem? Please describe.
I do many flashcards daily and sometimes a lightbulb lights over my head and I have an idea for creating a new note or I want to check a note on the browser. So I tap one of the app shortcuts, which is really easy on Samsung Edge Panel, and I open the Add note or Card browser activity. My issue is, all shortcuts of the app have the flag FLAG_ACTIVITY_CLEAR_TASK, so all the activities I used are gone when I tap a shortcut and I have to reopen everything after it

Describe the solution you'd like
Don't clear the previous activities when a shortcut is launched, just put the shortcut activity at the top, like with FLAG_ACTIVITY_REORDER_TO_FRONT

Describe alternatives you've considered
There is the Add note button on the reviewer, but I'm not always on the reviewer and there isn't a card browser button on the reviewer (maybe there should be one to be similar to Anki Desktop?), so I can't think of an alternative

@BrayanDSO
Copy link
Member Author

I want to implement it if it is accepted.

@BrayanDSO
Copy link
Member Author

Here's a demo. After tapping the Card browser shortcut, if I backpress, it closes the app instead of going to the previous screen/activity

Screen_Recording_20220419-210210_One.UI.Home.mp4

@raymondwzeng
Copy link
Contributor

In the current implementation of the shortcuts, only 1 activity is launched, right? Unless that flag also prohibits navigation back to its parent activity (defined in XML).

@BrayanDSO
Copy link
Member Author

It clears all the tasks, this includes parent activities, so the launched activity is the only activity that remains (docs: FLAG_ACTIVITY_CLEAR_TASK)

@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Jun 20, 2022
@BrayanDSO
Copy link
Member Author

Later, bot

@github-actions github-actions bot removed the Stale label Jun 20, 2022
@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Aug 19, 2022
@BrayanDSO BrayanDSO removed the Stale label Aug 19, 2022
@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Oct 18, 2022
@BrayanDSO
Copy link
Member Author

No no no, little bot, this needs to stay open

@github-actions github-actions bot removed the Stale label Oct 18, 2022
@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Dec 18, 2022
@BrayanDSO BrayanDSO removed the Stale label Dec 19, 2022
@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Feb 17, 2023
@BrayanDSO BrayanDSO removed the Stale label Feb 17, 2023
@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label May 18, 2023
@BrayanDSO
Copy link
Member Author

This made an anniversary already. Maybe I should work on it

@raymondwzeng
Copy link
Contributor

@BrayanDSO Feel free to do so - I don't have as much time as I used to at the moment.

@github-actions github-actions bot removed the Stale label May 18, 2023
@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Aug 16, 2023
@BrayanDSO BrayanDSO removed the Stale label Aug 17, 2023
Copy link
Contributor

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Nov 15, 2023
@BrayanDSO BrayanDSO removed the Stale label Nov 15, 2023
@david-allison david-allison added the Keep Open avoids the stale bot label Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Keep Open avoids the stale bot
Projects
None yet
Development

No branches or pull requests

3 participants