Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask to keep data when uninstalling #13084

Merged
merged 1 commit into from Jan 9, 2023
Merged

Conversation

BrayanDSO
Copy link
Member

https://developer.android.com/guide/topics/manifest/application-element#fragileuserdata

Pull Request template

Purpose / Description

After scoped storage it is better to warn the user before uninstalling to avoid losing their collection

Approach

Add the corresponding tag to the manifest
https://developer.android.com/guide/topics/manifest/application-element#fragileuserdata

How Has This Been Tested?

On my phone, Android 13:

  • Tried to uninstall the app and see if the message to keep data appears

Learning (optional, can help others)

https://developer.android.com/guide/topics/manifest/application-element#fragileuserdata

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge Review High Priority Request for high priority review and removed Needs Review labels Jan 8, 2023
@david-allison
Copy link
Member

Optional: screenshot would be useful for posterity

Copy link
Contributor

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, didn't know about that option!

@lukstbit lukstbit merged commit a5d28ba into ankidroid:main Jan 9, 2023
@github-actions github-actions bot added this to the 2.16 release milestone Jan 9, 2023
@github-actions github-actions bot removed Review High Priority Request for high priority review Needs Second Approval Has one approval, one more approval to merge labels Jan 9, 2023
@BrayanDSO BrayanDSO deleted the fragileData branch February 17, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants