Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: "Limits start from top" incompatible with increased daily limit #15682

Open
3 of 4 tasks
virginviolet opened this issue Feb 26, 2024 · 5 comments
Open
3 of 4 tasks

Comments

@virginviolet
Copy link

virginviolet commented Feb 26, 2024

Checked for duplicates?

  • This issue is not a duplicate

Bug

When the "limits start from top" option is enabled, increasing the daily limit with custom story or increasing the "today only" does not work. It just doesn't increase the number of new cards available. And yes, I'm not out of new cards, of course.

Or maybe it's supposed to be like that and I've misunderstood something.

What are the steps to reproduce this bug?

Long tap a deck, select deck options.
Switch on "limits start from top".
Save.
Long tap any deck, select custom study, then "modify today's daily limit".
Enter any positive integer and tap OK.

Expected behaviour

More new cards.

Actual behaviour

No additional new cards.

Debug info

AnkiDroid Version = 2.17.1 (dd2f3762fb214f9dd51162b215974b23cc809713)

Backend Version = 0.1.34-anki23.12.1 (23.12.1 1a1d4d5419c6b57ef3baf99c9d2d9cf85d36ae0a)

Android Version = 14 (SDK 34)

ProductFlavor = full

Manufacturer = samsung

Model = SM-A346B

Hardware = mt6877

Webview User Agent = Mozilla/5.0 (Linux; Android 14; SM-XXXXX Build/UP1A.23XXXX.xxx; xx) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/122.0.6261.64 Mobile Safari/537.36

ACRA UUID = 73474d9c-c662-4436-afdd-f5404f157646

Crash Reports Enabled = true

(Optional) Anything else you want to share?

No response

Research

  • I am reporting a bug specific to AnkiDroid (Android app)
  • I have checked the manual and the FAQ and could not find a solution to my issue
  • (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)
@virginviolet
Copy link
Author

Oh... never mind. I had accidentaly(?) set the top deck to another deck category.

@virginviolet
Copy link
Author

virginviolet commented Feb 26, 2024

Buut... it seems like you... sometimes? have to increase the limit on the top deck, you cannot do it on a subdeck, even if they are the same category. I feel like that's s flaw. But I don't know, this thing is confusing the heck out of me, even though I want it!

@virginviolet virginviolet reopened this Feb 26, 2024
@brishtibheja
Copy link

How is that a flaw? If limits start from the top and the parent deck has a limit of 10 the child deck cannot possibly have a limit of 15 right?

@virginviolet
Copy link
Author

virginviolet commented Apr 24, 2024

How is that a flaw? If limits start from the top and the parent deck has a limit of 10 the child deck cannot possibly have a limit of 15 right?

I expected parent decks to have their temporary limit also increased if you increase a child deck. Partly because that worked before I enabled "Limits start from the top", and that was very practical. Instead, it seemed like nothing happened. But I guess you're right.

For some reason, this whole thing (limits) is very unintuitive and confusing for me. But I do prefer "limits start from the top", now that I've figured out how to work with it. I don't think I would have figured it out had I not made this issue.

Might I suggest the following feature/improvement?
When you increase the temporary limit of a child deck beyond the limit of its parent, the parent's limit get increased enough to fill the user's request. Perhaps with a dialogue asking the user to confirm that this is what they want. Though, I cannot imagine the user wanting anything else. This would save them from confusion (as in my case) and also save them time. I have three layers to some of my decks, and it's annoying to have to increase the temporary limit three times or more depending on how many child decks I want to study.

I guess it would also be nice if, when you increase the temporary limit of a parent deck, the app asks you if you want to replenish the child decks as well. This might not be something you always want to do, but it could be a quality of life improvement.

@brishtibheja
Copy link

brishtibheja commented Apr 25, 2024

I didn't read all of it but yeah I agree this whole limit thing has become confusing and unintuitive after V3.

But I guess you're right.

I said that but I've faced some issues with limits myself so now I'm not even sure.

Actually @virginviolet is this issue I logged somewhat related to yours? #16243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants