Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate ANRs from Play Console #4971

Closed
mikehardy opened this issue Sep 15, 2018 · 8 comments
Closed

Investigate ANRs from Play Console #4971

mikehardy opened this issue Sep 15, 2018 · 8 comments
Assignees
Labels
Dev Development, testing & CI

Comments

@mikehardy
Copy link
Member

Similar to a couple of the other issues tagged for 2.9 this isn't a blocker, but just to do a deep-dive on at least one of the ANR reports (there are lots) from the Play Console.

We already have a lot of AsyncTask implementation so it may be that there are just a few things that need the same treatment, or maybe we have a general problem that needs a design look, or maybe it's not worth the effort

The goal of this issue is just to look and report back

https://developer.android.com/training/articles/perf-anr#java

This one affected 102 people in the last 30 days for instance:

#4 pc 0000000000103bc4 /data/app/com.ichi2.anki-lj74a1ISsYq3tmKTPndlFA==/oat/arm64/base.odex (Java_io_requery_android_database_sqlite_SQLiteConnection_nativeExecuteForChangedRowCount__JJ+180)
at io.requery.android.database.sqlite.SQLiteConnection.nativeExecuteForChangedRowCount (Native method)
at io.requery.android.database.sqlite.SQLiteConnection.executeForChangedRowCount (SQLiteConnection.java:762)
at io.requery.android.database.sqlite.SQLiteSession.executeForChangedRowCount (SQLiteSession.java:764)
at io.requery.android.database.sqlite.SQLiteStatement.executeUpdateDelete (SQLiteStatement.java:68)
at io.requery.android.database.sqlite.SQLiteDatabase.executeSql (SQLiteDatabase.java:1676)
at io.requery.android.database.sqlite.SQLiteDatabase.execSQL (SQLiteDatabase.java:1668)
at com.ichi2.libanki.DB.execute (DB.java:296)
at com.ichi2.libanki.Media.removeFile (Media.java:960)
at com.ichi2.anki.DeckPicker.deleteUnused (DeckPicker.java:1248)
at com.ichi2.anki.dialogs.MediaCheckDialog$2.onNegative (MediaCheckDialog.java:128)
at com.afollestad.materialdialogs.MaterialDialog.onClick (MaterialDialog.java:356)
at android.view.View.performClick (View.java:6256)
at android.view.View$PerformClick.run (View.java:24710)

Might be a good candidate

@mikehardy mikehardy added this to the v2.9 release milestone Sep 15, 2018
@mikehardy mikehardy self-assigned this Sep 15, 2018
@mikehardy
Copy link
Member Author

ANR watchdog integrating with ACRA (and maybe an analytics tag) looks like a good way to instrument this, for what it's worth.

https://github.com/ACRA/acra/wiki/AdvancedUsage#catching-application-not-responding-errors-anr

Be mindful of report size and maybe only report main thread stack:
SalomonBrys/ANR-WatchDog#29 (comment)

@mikehardy
Copy link
Member Author

This is going to have to wait until after 2.9 unless someone else has time

@mikehardy mikehardy removed this from the v2.9 release milestone Oct 14, 2018
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2020

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@david-allison
Copy link
Member

Let's give it another cycle. We're in a much better place to start tackling ANRs

@mikehardy
Copy link
Member Author

Yeah, been really enjoying the stats. We just got to the place, with 2.10.2+ where the crashes are below the ANRs, possibly for the first time in AnkiDroid history (I haven't looked at ANRs past more than a year, definitely for more than a year crashes were the only thing that mattered)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2020

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Aug 2, 2020
@david-allison david-allison added Dev Development, testing & CI and removed Stale labels Aug 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2020

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@mikehardy
Copy link
Member Author

Started this process, already logged one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Development, testing & CI
Projects
None yet
Development

No branches or pull requests

2 participants