Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: select card and export them #8045

Closed
Arthur-Milchior opened this issue Jan 23, 2021 · 9 comments · Fixed by #12524
Closed

Feature request: select card and export them #8045

Arthur-Milchior opened this issue Jan 23, 2021 · 9 comments · Fixed by #12524

Comments

@Arthur-Milchior
Copy link
Member

Following upstream, I believe it would be nice to be able to select card(s) in the deck browser and have an option to export them. It would be especially useful to share buggy card for debugging or to share a card type with an example without needing to share a whole deck or create it

@TarekkMA
Copy link
Contributor

I'm going to try to implement this feature

@TarekkMA
Copy link
Contributor

TarekkMA commented Mar 10, 2021

I have ported the feature from the pylib anki, and added a menu item to export selected cards from the CardBrowser activity.

But the issue is the exporting methods is tightly coupled to DeckPicker activity.

I'm thinking about creating a helper class named ExportHelper and both CardBrowser and DeckPicker will delegate the exporting functionally to it. And only handle onActivityResult()

ExportHelper will control the prograssbar and other dialogs, the listener, and exportToProvider function

Interested to hear your thoughts about this

@Mohaned-Elfeky
Copy link
Contributor

can I work on this if this issue is still open?

@david-allison
Copy link
Member

Thanks for the interest! There's an open pull request which will close this, so it'd be best to work on something else.

@Mohaned-Elfeky
Copy link
Contributor

ok

@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label May 28, 2021
@Arthur-Milchior Arthur-Milchior added Keep Open avoids the stale bot and removed Stale labels May 28, 2021
@simranBhamra
Copy link

@Arthur-Milchior Is this issue still open? I see there was a pull request that went stale and you mentioned in a comment that it was better to pick a different issue. However, since this is still open is would I be able to work on this for a school project?

@Arthur-Milchior
Copy link
Member Author

Since Tarekk leaved us, it would be great to have someone taking the issue over and closing it. You can probably either use the commits from the existing PR, rebase them onto master and resolve the conflicts. You can also read them to inspire you and create your own PR. Or you can create a PR from scratch (but I doubt it's the best idea)

@dae
Copy link
Contributor

dae commented Jul 18, 2022

See #8159 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment