Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show queue top and bottom when repositioning a card #9458

Open
voidplayer opened this issue Aug 26, 2021 · 15 comments
Open

Show queue top and bottom when repositioning a card #9458

voidplayer opened this issue Aug 26, 2021 · 15 comments
Labels
Anki Ecosystem Compatibility Help Wanted Requesting Pull Requests from volunteers

Comments

@voidplayer
Copy link

My only use case for reposition cards is to put them at the top of it

Desktop shows the top and the bottom of the stack in the reposition dialog and it would be neat if ankidroid showed it too

@mikehardy
Copy link
Member

Interesting? Can you include some screenshots of desktop behavior?

@voidplayer
Copy link
Author

image

@mikehardy mikehardy added Help Wanted Requesting Pull Requests from volunteers and removed Needs Triage labels Aug 26, 2021
@VladThodo
Copy link
Contributor

@mikehardy, I've been able to implement a new dialog type and it currently looks like this. However, I don't necessarily understand what queue top and bottom refer to (I'm a bit of a newbie with Anki - development wise and usage wise), so any help regarding this would be much appreciated. It also seems like I need two new strings for this, as I wasn't able to find anything similar in the XML files.

Screenshot_2021-09-01-18-00-53-951_com ichi2 anki

@mikehardy
Copy link
Member

I have to apologize and say, I honestly don't know either 😆 - I'm busy enough managing AnkiDroid itself and just doing my personal Anki reviews that I don't have enough time to keep up with new things. I'm more like a janitor then a trend-setter I guess.

But perhaps @david-allison-1 knows?

That said: new strings are fine - just add them to only the values directory (not the translated directories) and our translation infrastructure will handle the rest

@voidplayer
Copy link
Author

voidplayer commented Sep 1, 2021

image

New cards have an assigned value that determine the position in the new queue (in the screenshot it goes from 125 to 143)

In my first screenshot, the first card in the new queue has value 51 (top) and it will be the next new card shown

Last card in new has value of 15240 (botton) and it will be the last to be presented in the new queue

I dont think this is a new feature. This has been there for as long as i can remember...

@mikehardy
Copy link
Member

I dont think this is a new feature. This has been there for as long as i can remember...

It's also quite possible (actually, it's true) that I'm pretty boring and my use of available tools is usually in the simplest manner possible so I don't use 90% of features ;-)

@voidplayer
Copy link
Author

voidplayer commented Sep 1, 2021

Hey whatever gets the job done for you ;)

I discovered recently that reviewing new cards sooner after adding them rather than later helps me remember them like a lot

Maybe it only helps in the context of new vocabulary, but after many months testing it, this is a no brainer for me now :)

@david-allison
Copy link
Member

david-allison commented Sep 1, 2021

This has been a feature for years.

New cards are in a queue, lower numbered cards are shown before high numbered cards

Cards can, but shouldn't have a duplicate position in the queue


I /believe/ this is [cards].due for new cards, note: this does not match our database documentation, and the documentation should likely be fixed after this is confirmed.

image

EDIT: Removed incorrect suggestion regarding other places to change

@david-allison
Copy link
Member

My only use case for reposition cards is to put them at the top of it

Desktop shows the top and the bottom of the stack in the reposition dialog and it would be neat if ankidroid showed it too

Untested, but I believe you can stick something at position 1, and that should bring it to the top

@voidplayer
Copy link
Author

Where is this stick at position 1 option?

@david-allison
Copy link
Member

david-allison commented Sep 1, 2021

It's not an option, refers to leaving the "start position" at 1

@voidplayer
Copy link
Author

Oh, i see

Thats true, but It shifts every card position... It turns insta syncs into syncs that take a while

@david-allison
Copy link
Member

Oh, i see

Thats true, but It shifts every card position... It turns insta syncs into syncs that take a while

Apologies - I wasn't aware of that, definitely not ideal then

@VladThodo
Copy link
Contributor

This is what card.getDue() returns after each change (for new cards), so it appears that repositioning sets the card's "due" to whatever I happen to give it as an input in the dialog. I guess this is what I was looking for, right?

2021-09-01 20:54:30.865 14577-14577/com.ichi2.anki D/CardBrowser: Card due: 2
2021-09-01 20:54:45.867 14577-14577/com.ichi2.anki D/CardBrowser: Card due: 20
2021-09-01 20:54:53.449 14577-14577/com.ichi2.anki D/CardBrowser: Card due: 107
2021-09-01 20:55:02.728 14577-14577/com.ichi2.anki D/CardBrowser: Card due: 243
2021-09-01 20:55:11.030 14577-14577/com.ichi2.anki D/CardBrowser: Card due: 923

@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Oct 31, 2021
@david-allison david-allison added Keep Open avoids the stale bot and removed Stale labels Oct 31, 2021
@david-allison david-allison removed the Keep Open avoids the stale bot label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Anki Ecosystem Compatibility Help Wanted Requesting Pull Requests from volunteers
Projects
None yet
Development

No branches or pull requests

4 participants