Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ace Editor Overrides #286

Closed
willcosgrove opened this issue Oct 20, 2013 · 3 comments
Closed

Ace Editor Overrides #286

willcosgrove opened this issue Oct 20, 2013 · 3 comments
Labels
bug Bug report
Milestone

Comments

@willcosgrove
Copy link

Thanks for an awesome plugin! I noticed you override Ace styles. This causes all Ace editors all across the web to have your styles, which messes up how the text looks. Like when there's a black background, and the text has been forced to black.

It might be a better idea to write a custom theme, and use that, so you aren't changing them globally across every site.

@ankit
Copy link
Owner

ankit commented Nov 27, 2013

Yes, this is in the pipeline of things that need to be fixed...Thanks for bringing it to my attention again...I will try and get a fix in the next update. Thanks for using stylebot!

@xPaw
Copy link

xPaw commented Dec 15, 2013

Just got hit by this issue, would be nice to have it fixed sooner rather than later.

@dredmorbius
Copy link

My thought: explicitly style all elements used within Stylebot. Use a long and random ID to define those styles.

Location of the styles in the page isn't going to solve all problems.

Assuming you haven't already fixed this (looking at a5609b9).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report
Projects
None yet
Development

No branches or pull requests

4 participants