Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UUID enhancement #140

Closed
peter279k opened this issue Apr 28, 2019 · 1 comment · Fixed by #196
Closed

UUID enhancement #140

peter279k opened this issue Apr 28, 2019 · 1 comment · Fixed by #196
Labels
good first issue hacktoberfest improvement
Milestone
v1.1.0

Comments

@peter279k
Copy link

peter279k commented Apr 28, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.

According to the Warning and Caution block in official reference, the uniqid will not be
the cryptographically secure value.

And it may be the collision value.

image

Describe the solution you'd like

I think we can implement the UUIDv5 method or including PHP uuid package.
@ankitpokhrel
Copy link
Owner

@peter279k PR would be great :)

@claudiunicolaa claudiunicolaa mentioned this issue Oct 1, 2019
Merged
@ankitpokhrel ankitpokhrel added this to the v1.1 milestone Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue hacktoberfest improvement
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Replaced uniqid with Ramsey\Uuid\Uuid +uuid4() claudiunicolaa/tus-php
2 participants
@ankitpokhrel @peter279k