Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PSR-12 #189

Closed
ankitpokhrel opened this issue Sep 28, 2019 · 0 comments · Fixed by #364
Closed

Switch to PSR-12 #189

ankitpokhrel opened this issue Sep 28, 2019 · 0 comments · Fixed by #364
Labels
Milestone

Comments

@ankitpokhrel
Copy link
Owner

ankitpokhrel commented Sep 28, 2019

PSR-2 is deprecated and PSR-12 is now recommended as an alternative. We need to update our cs-fixer config and apply changes to our codebase after PHP-CS-Fixer implements the @PSR-12 group.

Waiting for: PHP-CS-Fixer/PHP-CS-Fixer#4502

Provisional Ruleset

[
    '@PSR2' => true,
    'blank_line_after_opening_tag' => true,
    'braces' => ['allow_single_line_closure' => true],
    'compact_nullable_typehint' => true,
    'concat_space' => ['spacing' => 'one'],
    'declare_equal_normalize' => ['space' => 'none'],
    'function_typehint_space' => true,
    'new_with_braces' => true,
    'method_argument_space' => ['on_multiline' => 'ensure_fully_multiline'],
    'no_empty_statement' => true,
    'no_leading_import_slash' => true,
    'no_leading_namespace_whitespace' => true,
    'no_whitespace_in_blank_line' => true,
    'return_type_declaration' => ['space_before' => 'none'],
    'single_trait_insert_per_statement' => true,
];
@stale stale bot added the inactive label Dec 18, 2019
Repository owner deleted a comment from stale bot Dec 18, 2019
@ankitpokhrel ankitpokhrel added this to the v3.0 milestone Nov 21, 2020
@ankitpokhrel ankitpokhrel mentioned this issue Nov 21, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant